Version: 1901081935550
Baseline: 1901021931380
- Rename test/functional dir to test/unit (#20185)
- Extern list for 3p ad context attributes (#20172)
- ✨Apester Media (extension): Embed 3rd party pixel #18858 (#18956)
- use writeScript instead of loadScript (#19614)
- Validator rollup (#20191)
- Fix flaky ordering in test-performance (#20188)
- amp-form mustache template rendering doc height update (#20144)
- ✨ Add Navegg as A4A vendor (#18402)
- Allowing clicking through the system layer to navigate. (#20179)
- Adds
load-more-clickable
attribute foramp-list-load-more
(#20147) - ✨Add a go to page action (#20084)
- Make 'untrusted viewer url override' an expected error (#20140)
- ✨ Mark the document visible timestamp in browser timeline (#19918)
- ♻️Reference the Event object from the gesture.event property (#20155)
- Report the SHA of the base (merged
master
) commit in bundle-size checks (#20153) - ✨ amp-animation: Added length() function. (#20139)
- Add no-restricted-globals lint rule and exceptions (#20137)
- 🏗 Refactor git merge base functions (#20151)
- Docs update for amp-list load-more (#19967)
- 🐛amp-recaptcha-input: Fixed Copyright year on Validator HTML Test (#20145)
- Remove multi consent prompt support (#20101)
- 🏗✨ Add boilerplate for video
seekTo
, implement foramp-video
(#19893) - ✨/ ♻️amp-recaptcha-input: Added Validation tests / Updated Validation Documentation (#20131)
- Fix changelog baseline (#20030)
- Remove
skip[Chrome|Firefox]Dev
from test platform (#20018) - Tidy up the test gulp task (#20117)
- Stop amp-sidebar from forwarding hotkeys to viewer (#20129)
- ✨amp-brightcove: extend analytics support (#20067)
- ✨Amp Form - Async Input / amp-recaptcha-input Support (#19334)
- Minor fix to analytics vendor example page (#20124)
- Introduce cta-landing-page-type for story ads (#20051)
- Update mparticle.js to allow custom page names (#19932)
- 🚮Cleanup
amp-story-scaling
experiment (#19888) - Update presubmit check to require copyright for 2019 (#20119)
- 🐛: Adding UpScore to Vendor.js (#20069)
- 🐛 Prevent context menu in stories (#20058)
- Adding PUB_UUID publisher defined macro to aps callout vendor URL (#19936)
- Save bookend state in window history (#19491)
- Click through the system layer when hidden. (#20048)
- removed authentication section (#19424)
- 🚮 Remove
amp-video-iframe
experiment guard (#19887) - AMP MowPlayer - Responsive Feature (#19721)
- Remove support to multiple consent instance (#20089)
- Update error handling after each Mocha test (#20091)
- 🐛amp-consent: Fixed the flash of the leftover CMP Iframe Container (Flash of teal) (#20086)
- Fix flaky amp-bind + list tests (#20065)
- Update dependency eslint-plugin-eslint-plugin to v2.0.1 (#20081)
- Update dependency eslint to v5.11.1 (#20080)
- Update dependency cssnano to v4.1.8 (#20079)
- ✨Exit lightbox overlay mode before animation. (#20085)
- 🖍amp-consent: Added Additional Styling to amp-consent CMP UI (#20088)
- Update dependency @ampproject/animations to v0.1.1 (#19995)
- 🐛Fix lightbox transition when things on the page have z-index (#20078)
- Add assertArray function to log.js (#19937)
- Update dependency ava to v1 (#19903)
- Update dependency @octokit/rest to v16.3.0 (#20000)
- Update dependency autoprefixer to v9.4.3 (#19907)
- Update dependency rollup to v0.68.2 (#19906)
- Update babel monorepo (#19902)
- Update dependency jsdom to v13.1.0 (#19901)
- Update dependency ajv to v6.6.2 (#19522)
- Revert "Remove the whole statement when stripping asserts/logs when possible. (#20033)" (#20077)
- Update dependency nodemon to v1.18.9 (#19764)
- Update react monorepo to v16.7.0 (#20025)
- Update dependency find-imports to v1 (#20028)
- Attempt to stabilize amp-list integration tests (#20063)
- 🏗 Print a warning on Travis if a PR's commit log is unexpectedly long (#20061)
- Fix: Dont install SW via amp-install-serviceworker for safari (#19922)
- Amp install sw custom scope (#19915)
- Remove amp custom runner part 2 (#19913)
- Fix: Uses active service worker to postMessage between main thread and sw (#19910)
- Migrate user().assert to userAssert (#20047)
- Try to fix integration tests flakiness (#20062)
- Fire the selected event via toggle action. (#19861)
- Remove unused load-end event (#20036)
- Revert part of #19947 and #19680 which caused race condition for amp-analytics layout (#19963)
- Fix Ampcontext variables in singlepass (#19987)
- Make dep-check an order of magnitude faster. (#20050)
- ⏪ Rollback #20040, which breaks touch events in stories (#20053)
- 🐛 Remove duplicate visual test (#20054)
- ✨Pass consent string to 3p ad vendors (#19985)
- Correctly tear down previous request in requestBank (#20037)
- Increase timeout to fix flakiness of attemptChangeSize request (#20024)
- Remove the whole statement when stripping asserts/logs when possible. (#20033)
- ✨New action for closing or navigating a window. (#19962)
- 🐛 Prevent context menu from appearing on hold to pause (#20040)
- Refactor dev().assert to devAssert (#20019)
- Move externs that are only needed in multipass compilation into separate file (#20032)
- ✅ Stop depending on the share pill being visible, since it is now hidden (#20039)
- No amp4test log on travis. (#19611)
- Add special case to inline new assert function. (#20029)
- Increase timeout for some flaky tests (#20016)
- 🐛Allowing publisher URL to be picked up so that recommendation ads could be provided accordingly (#19986)
- ✨amp-consent Consent UI Scroll Locking [Mask in follow up PR] (#19125)
- update comment (#19971)
- Edit amp-sidebar to default to side="right" for stories ✨ (#19595)
- ✅ Hide the share pill in visual tests, and re-enable tests that were flaky because of this (#20022)
- ✨ Add Amplitude as an analytics vendor (#19973)
- Register default actions programmatically. (#19032)
- Pass head node, not documentElement, to refactored services (#20013)
- Update dependency karma to v3.1.4 (#19934)
- Update dependency eslint to v5.10.0 (#19739)
- Update dependency typescript to v3.2.2 (#19534)
- 🏗📖 Add instructions to the legacy bundle size failure message (#20012)
- 🏗 Roll back version of
moment
and move it todependencies
so it doesn't get auto-updated (#19998) - Rewrite some amp-bind integration tests (#19895)
- 🐛Set default UI for amp-sidebar within amp-story (#19459)
- Set theme-color to page background color 🐛 (#19921)
- Actually make type inference work for asserts. (#19940)
- fix amp-ad-exit in singlepass (#19831)
- Enforce no mix interpolation (#19700)
- Mute failing assertion instead of the whole test. (#16828)
- Refactor lightbox gallery to use htmlFor (#19972)
- [amp-list-load-more] Bring back the loader (#19991)
- Adding OnNetwork AD Subsystem to ADS (#19975)
- add test for inabox BTF (#19996)
- ✨amp-consent-ui: Improved the CMP amp-consent demo (#19992)
- 🐛amp-story-auto-ads: stringify objects in config (#19994)
- Remove bundle size check from pre-push hook (#19993)
- ✨Implemented Fuzzy Search through an API on the Dev Dashboard (#19676)
- Add support for opening Chrome with passed in flags (#19636)
- Update dependency eslint-plugin-jsdoc to v3.14.1 (#19979)
- Update dependency moment to v2.23.0 (#19865)
- ✨AMP-Analytics: Add Analytics Vendor Pinpoll (#19578)
- Add Inabox integration test (#19711)
- Allow us to locally run tests on Chrome Canary. (#19628)
- 🏗 Limit commit log size in Travis logs and print branch point info (#19984)
- Better A4A/FIE testing, add FIE services regression test (#19943)
- disable pagination buttons desktop test (#19917)
- ✅Enable skipped singlepass tests (#19844)
- 🏗 Refactor branch point logic and print a change summary before running PR checks (#19954)
- Improve google matched content responsive ad logic. (#19862)
- Fix the link to the HTML attributes section (#19953)
- ✨amp-consent: Added a default loading placeholder for the consent UI (#19841)
- Validator roll up (#19965)
- 📖 Update buildcop.md with beta browsers instructions (#19929)
- 🐛Story ads: show one page sooner on desktop (#19900)
- ✨ Recognize details element with open/[open] attributes and summary child element (#18440)
- Add visual test for AMP Inabox with GPT (#19345)
- ♻️ amp-viqeo-player: placeholder and refactoring (#19885)
- import css (#19947)
- Remove all references to loadMoreLoadingOverlay (#19942)
- Fix CSS transitions on sidebar (#19811)
- [amp-list] resize amp-list on viewport resize experiment (#19946)
- Upgrade RobinHerbots/inputmask to 4.0.4 (#19925)
- Fix copyright date on amp-access-poool files (#19928)
- Add integration test for amp-analytics various triggers. (#19707)
- [amp-list-load-more] bugfixes, code cleanup, fix demos (#19881)
- 🏗🐛 Fix bug in git branch point logic (#19933)
- fix a4a intersection observer (#19838)
- Refactor EmbeddableService (#19771)
- Mark
babel-plugins
files as affecting the runtime in thegulp pr-check
task (#19920) - Skip flaky tests on Chrome 71 + Windows 10 (#19926)
- Avoid showing mask characters until the user reaches them (#19927)
- Run integration tests on SauceLabs with beta browser versions, and make these beta versions non-failing (#19874)
- ✨ Implement new amp-access-poool extension (#18700)
- ✨ Bindable [src] for (#19894)
- Story supports-landscape attribute validation. (#19872)
- Story supports-landscape attribute. (#19849)
- ♻️amp-consent: Refactored consent ui api to match consent response (#19860)
- Remove wait for ini-load when layout a4a (#19738)
- 🏗🐛 Remove
refreshKarmaWdCache
, sincekarma-sauce-launcher
no longer depends onwd
(#19889) - 🚮Remove
amp-story
codepath for page-scaling experiment (#19877) - Fix flaky tests in test-custom-element.js (#19853)
- adding babel plugin for
IS_DEV
andIS_MINIFIED
transformation (#19690) - 🐛🏗 Fix mask appearing on hover. Use patch pattern (#19873)
- 🚀 Hoist templates and ensure duplicates are not added to bundle (#19812)
- Update dependency karma-sauce-launcher to v2.0.2 (#19845)
- Disallow passing ampdoc to FIE service getters (#19730)
- Remove i-amphtml-element class on forced disconnect (#19858)
- Update amp-animation.md (#18000)
- add fb-me and wh protocols for anchor and social-share (#19871)
- Add DOMPurify externs (#19815)
- ✅amp-facebook: tests for sandboxing and remove exception for
amp-embedly-card
#19851 - 🐛 Fix FixedLayer attribute sync for amp-bind (#19805)
- Update dependency karma to v3.1.3 (#19571)
- Removes code that forces fixed layout on multi-size slots. (#19848)
- ✨maximum-nights attribute on amp-date-picker (#19854)
- 🚀🐛 Make video docking completely scroll-triggered (#19735)
- 🐛Fix wrong carousel slide being shown when closing lightbox. (#19834)
- add aaron to consent owner (#19855)
- Update dependency postcss to v7.0.6 (#19377)
- update fixed layer (#19830)
- ✅ Restore tests disabled on SauceLabs before #19832 (#19843)
- Fix off-by-one in freeze dates (#19846)
- fix __AMP_TOP and __AMP_PARENT globals getting obfuscated (#19833)
- Opaque bookend with no blur on mobile. (#19806)
- 🖍 Added two default elements for amp-list-load-more (#19703)
- Replace test server port from 31862 to 8081 for better proxy support in SauceLabs (#19832)
- Fix non-inclusive between check for min and max (#19827)
- Exclude facebook for iframe sandbox (#19828)
- Exclude facebook for iframe sandbox (#19828)
- Fix duplicate items bug (#19772)
- 🐛 Amp subscriptions reset fixes. (#19689)
- Update dependency rollup-plugin-babel to v4.1.0 (#19818)
- Update dependency fancy-log to v1.3.3 (#19549)
- Fix amp-form chaching submit service reference before it's registered (#19824)
- create separate bug/feature templates (#19807)
- Add TODOs for skipped tests (#19797)
- Update dependency lazypipe to v1.0.2 (#19820)
- Update dependency autoprefixer to v9.4.2 (#19576)
- Update dependency google-closure-compiler to v20181125 (#19487)
- Fix amp-addthis single pass bugs (#19639)
- Add more tests to fixed-layer attr sync (#19809)
- Fix bug with fading in lightbox after image transition. (#19784)
- 🐛 Fix FixedLayer attribute sync for amp-bind (#19805)
- 🐛 Patch web-animations-js polyfill to avoid writing to readonly property (#19785)
- Publisher opt in into a story landscape fullbleed desktop + mobile experience. (#19646)
- add default title/etc. (#19732)
- ✅ Skip mutliple flaky tests (#19796)
- Validator rollup (#19794)
- Update dependency karma-sauce-launcher to v2 (#19781)
- Update dependency @octokit/rest to v16 (#19418)
- Update dependency sinon-chai to v3.3.0 (#19464)
- Update dependency karma-browserify to v6 (#19566)
- ✅🏗 Reduce SauceLabs batch size and remove flaky browsers to unblock master (#19782)
- Add SwG team to amp-subscriptions and amp-subscriptions-google owners (#19780)
- Update dependency @ampproject/animations to v0.1.0 (#19569)
- Wait for ampdoc to fully load before creating default element. (#19778)
- 🐛 [amp-analytics] Pass the canonical url on every Parse.ly Analytics pageview request (#19425)
- [amp-story] Refactor pagination buttons to use store ♻️ (#19655)
- 🚀 HTML Template Tag Transform to eliminate poor transpilation issues (#19704)
- SwG release 0.1.22.41 (#19776)
- Added new partner for analytics: Retargetly (#19556)
- Add failure demos, fix race condition for not showing load-failed element (#19770)
- Disallow passing ampdoc to Services.urlForDoc() (#19602)
- Edit documentation (#19746)
- Disable two flaky CustomElement tests (#19760)
- [WIP] amp-date-display (#19445)
- Fix paywall display conditions (#19733)
- 🏗 Stop printing a console error summary at the end of full test runs (#19726)
- Update dependency rollup to v0.67.4 (#19574)
- Update dependency rollup-plugin-node-resolve to v4 (#19745)
- Update babel monorepo (#19587)
- Update docs to replace doubleclick with Google Ad Manager (#19756)
- fixing method call for esm build (#19691)
- Update dependency preact to v8.4.2 (#19701)
- Update dependency ansi-colors to v3.2.3 (#19610)
- Remove dead links in amp-access-analytics doc (#19588)
- ✨ Keep the highlighted text color consistent with Android Chrome. (#19649)
- ✨ amp-analytics Nested Value Template Expansion (#19609)
- Update dependency eslint-plugin-jsdoc to v3.14.0 (#19717)
- Update dependency eslint-plugin-eslint-plugin to v2 (#19740)
- Add more browsers to integration tests (#19630)
- ✅ Disable flaky CustomElement test (#19750)
- Add script tag support for enclosing a template (#19346)
- Fix paywall display conditions (#19733)
- Moved 3p bootstrap frame definitions into
build-system/config.js
(#19681) - ✨19607 Additonal Unit Tests for amp-consent-v2 enterFullscreen() (#19638)
- 🐛Allow amp-analytics to layout correctly in FIE (#19680)
- Fallback "Play video" message when the story video failed to play. (#19696)
- Delay and delegate the subscriptions platform selection call. (#19545)
- [amp-story] Add totalPages to AmpStoryStoreService (#19666)
- Document the need for integration test for 3rd party integration (#19668)
- Add integration tests for (#19674)
- ✨ add ads: baidu (#19489)
- 🗺Fix sourcemaps on devserver (#19724)
- Add integration test for CLIENT_ID in amp-analytics (#19709)
- ♻️Don't encode expandStringSync (#19667)
- ♻️ Refactor video docking controls (#19593)
- Skip tests failing on SL Chrome 71 (#19722)
- register localization service in system layer tests (#19725)
- update bindings in ssr. (#19660)
- Fix margins in amp-consent bookend component 🐛 (#19582)
- [amp-story] Stop stubbing querySelectorAll in tests 🐛 (#19718)
- 📖 [amp-geo] mention that testing only works in Chrome (#19720)
- Adding integration for AMPHTML ads rendered on AMP page (A4A) (#19698)
- Disable headless mode, fix tests broken on Chrome 71 (#19658)
- ✅ Allow amp-video-iframe[dock] (#19521)
- Fix test-linker-manager.js (#19695)
- 📖 Correctly format code blocks for
amp-action-macro
(#19679) - cl/224368866 Attrs requiring an extension also satisfy that extension is used (#19692)
- Disallow passing ampdoc to Services.urlReplacementsForDoc() (#19560)
- Fixes a bug in infinite scroll where load-end does not hide after binding src (#19677)
- 🐛 Amp subscriptions reset fixes. (#19689)
- Teardown RequestBank after a test finish. (#19613)
- Allow forcing the Custom Elements V1 Polyfill (#18190)
- Skip amp video tests that are failing when running alone (#19665)
- 🐛Force Collapsed amp-ad When They Are the Only Element Within Flying Carpet (#19415)
- 🐛Fixed Multiple Clicks from Amp Linker adding Duplicate Params (#19648)
- Update no-module-exports eslint rule (#19581)
- Fix button positioning for load-more elements as not to partially cover last item in amp-list (#19641)
- Remove Safari 11 on mobile from tests (#19669)
- Update SC to 4.5.2 (#19661)
- turn off fixer for now (#19663)
- Skip some flaky tests in test-friendly-iframe-embed. (#19651)
- Tweaking doc of
cookies
object (#19643) - Skip failing test (#19645)
- 🐛inabox: workaround to keep compiler from removing cross-domain check (#19632)
- 🐛inabox: workaround to keep compiler from removing cross-domain check (#19632)
- Skip failing test (#19645)
- Add new amp-analytics vendor: Permutive (#19506)
- 📖 Update amp-video-iframe docs (#19637)
- 📖 Amp-analytics: Document feature to write cookie to origin domain (#19590)
- ✨Add FreeWheel ad network (#19400)
- Move bundle-size check up in pr-check.js (#19621)
- ✨ analytics: Allow pings with totalVisibleTime=0 when spec has reportWhen (#19304)
- temporarily skip flakey amp-subscriptions test (#19626)
- Message Extraction: while removing assert methods as a preprocess step, add back in the type (#19441)
- Disallow ampdoc in Services.bindForDocOrNull() (#19512)
Breakdown by component
ads
Migrate user().assert to userAssert (#20047) ✨Pass consent string to 3p ad vendors (#19985) Refactor dev().assert to devAssert (#20019) 🐛Allowing publisher URL to be picked up so that recommendation ads could be provided accordingly (#19986) Adding OnNetwork AD Subsystem to ADS (#19975)amp-3q-player
Migrate user().assert to userAssert (#20047)amp-a4a
Migrate user().assert to userAssert (#20047) Refactor dev().assert to devAssert (#20019) Pass head node, not documentElement, to refactored services (#20013)amp-access-laterpay
Migrate user().assert to userAssert (#20047)amp-access-poool
Migrate user().assert to userAssert (#20047)amp-accordion
Migrate user().assert to userAssert (#20047) Refactor dev().assert to devAssert (#20019)amp-action-macro
Migrate user().assert to userAssert (#20047)amp-ad
Extern list for 3p ad context attributes (#20172) Fix Ampcontext variables in singlepass (#19987) ✨Pass consent string to 3p ad vendors (#19985) Refactor dev().assert to devAssert (#20019) 📖 Update data-loading-strategy doc (#20004) Adding OnNetwork AD Subsystem to ADS (#19975)amp-ad-custom
Refactor dev().assert to devAssert (#20019)amp-ad-exit
Migrate user().assert to userAssert (#20047) Refactor dev().assert to devAssert (#20019)amp-ad-network-adsense-impl
Rename test/functional dir to test/unit (#20185) Refactor dev().assert to devAssert (#20019)amp-ad-network-adzerk-impl
Refactor dev().assert to devAssert (#20019)amp-ad-network-doubleclick-impl
Rename test/functional dir to test/unit (#20185) Refactor dev().assert to devAssert (#20019)amp-addthis
📖Updating documentation for amp-addthis. (#20009)amp-analytics
Documents iframe transport response (#20174) ✨amp-brightcove: extend analytics support (#20067) 🐛: Adding UpScore to Vendor.js (#20069) ✨ Add Amplitude as an analytics vendor (#19973)amp-animation
✨ amp-animation: Added length() function. (#20139)amp-brightcove
✨amp-brightcove: extend analytics support (#20067)amp-consent
Remove multi consent prompt support (#20101) Remove support to multiple consent instance (#20089) 🐛amp-consent: Fixed the flash of the leftover CMP Iframe Container (Flash of teal) (#20086) 🖍amp-consent: Added Additional Styling to amp-consent CMP UI (#20088) ✨Pass consent string to 3p ad vendors (#19985) ✨amp-consent-ui: Improved the CMP amp-consent demo (#19992)amp-date-picker
Remove `skip[Chrome|Firefox]Dev` from test platform (#20018)amp-form
amp-form mustache template rendering doc height update (#20144) Remove `skip[Chrome|Firefox]Dev` from test platform (#20018)amp-fx-collection
Try to fix integration tests flakiness (#20062)amp-image-viewer
♻️Reference the Event object from the gesture.event property (#20155) Add no-restricted-globals lint rule and exceptions (#20137)amp-lightbox
📖 Fix link to image lightbox (#20149)amp-lightbox-gallery
✨Exit lightbox overlay mode before animation. (#20085) 🐛Fix lightbox transition when things on the page have z-index (#20078) Refactor lightbox gallery to use htmlFor (#19972)amp-list
Adds `load-more-clickable` attribute for `amp-list-load-more` (#20147) Attempt to stabilize amp-list integration tests (#20063) Try to fix integration tests flakiness (#20062) Increase timeout for some flaky tests (#20016) [amp-list-load-more] Bring back the loader (#19991)amp-pixel
Migrate user().assert to userAssert (#20047)amp-recaptcha-input
🐛amp-recaptcha-input: Fixed Copyright year on Validator HTML Test (#20145) ✨/ ♻️amp-recaptcha-input: Added Validation tests / Updated Validation Documentation (#20131) Pass head node, not documentElement, to refactored services (#20013)amp-sidebar
Stop amp-sidebar from forwarding hotkeys to viewer (#20129)amp-story
Allowing clicking through the system layer to navigate. (#20179) ✨Add a go to page action (#20084) 🐛 Prevent context menu in stories (#20058) Click through the system layer when hidden. (#20048) ⏪ Rollback #20040, which breaks touch events in stories (#20053) 🐛 Prevent context menu from appearing on hold to pause (#20040)amp-story-auto-ads
🐛amp-story-auto-ads: stringify objects in config (#19994)amp-subscriptions
Pass head node, not documentElement, to refactored services (#20013)amp-viewer-integration
Add no-restricted-globals lint rule and exceptions (#20137)validator
Validator rollup (#20191) cl/227595936 Revision bump for #20051 cl/227739879 Revision bump for #20131 ✨/ ♻️amp-recaptcha-input: Added Validation tests / Updated Validation Documentation (#20131) relates to #18829 relates to #2273This adds validation tests for the new amp-recaptcha-input
. With some help from @Gregable to get this working / validating correctly.
Also, updated documentation from the learnings @Gregable and I had from getting this going.
Introduce cta-landing-page-type for story ads (#20051)
This optional meta tag indicates the type of landing page for an amp story ad.
3 choices:
<meta name="amp-cta-landing-page-type" content="NONAMP">
<meta name="amp-cta-landing-page-type" content="AMP">
<meta name="amp-cta-landing-page-type" content="STORY">