Version: 1528909142235
- 🐛Report if defaultView is null in preconnect (#15993)
- 🏗 Exempt
build-system/
andtest/
from JSDoc requirements (#15994) - Sidebar should not close when toolbar is present (#15990)
- 🏗 Add amp-story-responsive-units experiment (#15962)
- Add support for binding to svg image (#15734)
- [amp-story-bookend] Replaces amp images to regular images in amp-story-bookend (#15904)
- Allow sending RTC with consentState policy adherence (#15951)
- Changes amp-story-bookend config to use camelcase (#15944)
- 🏗 Require JSDoc comments for all classes, methods, and functions in AMP code (#15977)
- Increment binding limit by 500 on user gesture (up to 2000) (#15985)
- Skip flaky tests (#15981)
- 🚀♻️Delegate autoplay using signal (#15952)
- 🐛 Work around Android blank frame issue (#15957)
- ✨ Add "gtag" vendor configuration. (#15915)
- Remove inline installation (#15970)
- Fix more test-amp-analytics.js failures due to expected console errors. (#15963)
- 🐛 make amp-geo use user().error() on bad json (#15877)
- 🐛 Undo
hostname
change on Safari and re-enable testing on latest version (#15853) - Migrate Navigation service to use Url service (#15731)
- Doubleclick experiment removing throttling for non-AMP creatives (#15954)
- Add experiment to disable amp-story desktop UI (#15937)
- 🏗 Allow duplicate error messages in
expectAsyncConsoleError
(#15936) - Scroll AMP doc to center highlighted elements in the viewport (#15791)
- Deal with clashing presets in amp-fx gracefully (#15938)
- Fix arrow keys disappear on second open bug (#15879)
- 🐛Support fullscreening
- Add simple test to run during local-changes test (#15935)
- Update eslint jsdoc preference (#15943)
- Mute expected error: BLOCK_BY_CONSENT (#15903)
- AMPHTML Email Spec (#14532)
- ♻️Introduce more functionality to new expander. (#15889)
- Fixing bookend prompt consent margin when no config. (#15929)
- amp-facebook-page resize to container width (#15917)
- Disallows
bookend-config-src
attr inamp-story
tag (#15846) - Deprecate dismiss consent translation key. (#15908)
- Specify error reporting url for media.net RTC (#15902)
- ✨Create amp-drive-viewer behind experiment (#15824)
- Adding translation keys for the bookend prompt consent link. (#15910)
- Add ability to not trigger amp-position-observer after first iteration (#15779)
- Add a prompt consent button in the v0.1 bookend. (#15905)
- Fix getAdContainer potential crash when the body element is called (#15880)
- Add consentHandlingOverride flag to ezoic ampad (#15646)
- Add a prompt consent button in the bookend. (#15897)
- Fixing the bookend article layout. (#15899)
- Allow publisher defined consent policy (#15724)
- Update whitelist (#15896)
- Update whitelist (#15841)
- Update whitelist: 2018-06-07 (#15896)
- 🐛 amp-next-page: Fix trying to rewrite canonical URLs to cache URLs when it shouldn't (#15831)
- Update path and params for wisteria ad. (#15890)
- ✨ Provides a "Continue Anyway" button when stories are rendered on unsupported browsers (#15382)
- Fixing the consent ID used by amp-story-consent. (#15881)
- ✨Add New Ads Network - Epeex (#15676)
- Stories paused state, and state machine. (#15874)
- ♻️ Extract common video iframe helpers (#15527)
- ✅ Update AMP by Example visual test pages (#15854)
- ♻️ Remove once() (#15739)
- Wisteria amp-ad support (#15625)
- 🐛 Register localization service in amp-story 1.0 tests (#15806)
- ♻️ Port amp-story info dialog to 1.0 (#15872)
- 🏗 Enable amp-story-v1 experiment in canary and production (#15869)
- Fix test-integration.js (#15766)
- Validator rollup (#15873)
- 🚮 Gdpr Update: Removing Unnecessary GDPR Macros (#15849)
- 🌐 Add translations for new batch of strings (#15737)
- Avoid sanitizing 'on' attr with DOMPurify (#15820)
- amp-3d-gltf: fix test (#15860)
- amp-3d-gltf: fix src attribute (#15832)
- ✨Adds AMP-to-AMP linking support in amp-story bookend components (#15558)
- ♻️ adds support for bookend config v1.0 in amp story v0.1. (#15761)
- Refactor Real Time Config code (#15595)
- 🏗 Reinstate verification of Percy builds during PR checks (#15855)
- ♻️ Remove src/url requirement from amp-app-banner (#15692)
- Noddus ad-tech integration (#15303)
- SwG release 0.1.22.13 (#15838)
- Attempt to enable Safari 11.0 on SL (#15798)
- Skip Safari tests and use Safari 11.0 for 'latest' for now (#15762)
- 📖 Introduces documentation for new bookend components. (#15465)
- 🐛 Prevent setting min/max width/height on standalone amp-story elements (#15842)
- Whitelist origins for amp-story: week of 2018-06-05 (#15841)
- Fix carousel scroll on unlayout race condition trying to access non-existant slide (#15823)
- ♻️ Remove src/url requirements from amp-next-page (#15840)
- Added support for analytics on AMP pages for piStats (#14797)
- Fix extension generator name in spec url (#13472)
- 🚀 Autoplay with PositionObserver (#15750)
- Bump bundle size after #15784 (#15808)
- Add microtask delay to avoid race. (#15784)
- Add sample instructions for modifying code via content-scripts (#15747)
- Remove flaky/non-functional integration tests (#15839)
- Fire amp-ini-load event/postMessage on inabox ini-load event (#15835)
- Fix flaky performance test on Safari (#15836)
- 🐛 fix alpha attribute (#15829)
- Doubleclick remove fast fetch upgrade predicate (#15804)
- Subscriptions: propagate URL vars for ACCESS_READER_ID and AUTHDATA (#15770)
- 🐛 Prevent double / async errors from being thrown during tests (#15815)
- Lower-case amp-3d-gltf attribute names. (#15817)
- amp-list: Measure effect of disabling pre-gesture evaluation (#15694)
- 📖 amp-html-components.md: Fix broken links (#15785)
- Add TextHighlighter to amp-viewer-integration (#15337)
- Bump bundle size after #15784 (#15808)
- Attempt to enable Safari 11.0 on SL (#15798)
- Disambiguate amp-install-sw docs (#15746)
- Add microtask delay to avoid race. (#15784)
- ✨ adds title to portrait component in amp-story-bookend and change expected fields in articles (#15720)
- Ramp up native srcset experiment to 70% (#15754)
- Resolve url macros synchronously (#15681)
- Remove the language hack in amp-consent for stories documentation. (#15797)
- Medyanet Ad Network Update for Domain Data (#14609)
- Add integration tests for actions (#15714)
- Update amp-story-info-dialog.js (#15733)
- Fix tests of files using localization service (#15743)
- videos: various fixes and cleanups (#15776)
- Doubleclick sticky sra fix (#15781)
- Remove the AMP Validator release changelog now that releases are more (#15777)
- Prototype for with svg support only (#15545)
- Fix test-amp-analytics.js (#15749)
- Code and tests (#15760)
- Only delegate login actions for auto servcie (#15771)
- Skip Safari tests and use Safari 11.0 for 'latest' for now (#15762)
- Add integration tests for <amp-fx="fly-in-{bottom,left,right}"> (#15682)
- Throw user error when promptUI and postPromptUI are not scoped (#15604)
- Run visual diffs on PRs that modify (prod|canary)-config.json (#15738)
- Add new AD network - Realclick (#15084)
- ✨ geo service enhancement (#15726)
- ✨ Add Relap v7 widget support (#13738)
- Allow canonical adsense to work via new frame get (#15422)
- 🐛 Always use the
app
middleware in server.js, regardless of quiet mode (#15717) - Added the data-multi-size param to the endpoint. (#15599)
- ♻️ Move isSecureUrl into URL Service (#15614)
- ♻️ Remove src/url requirement from amp-install-serviceworker (#15713)
- Fix amp-list w/o amp-bind with disable-faster-amp-list enabled. (#15722)
- Fix amp-list w/o amp-bind with disable-faster-amp-list enabled. (#15722)
- ✨ Add geo support to user notifications (#15648)
- 🐛 Fix pre-push messages (#15711)
- Remove two-way messaging docs. (#15697)
- Resource#whenWithinRenderOutsideViewport resolve when within viewport (#15663)
- Remove src/url requirement from amp-social-share (#15691)
- ♻️ Remove
src/url
requirement from amp-video and VideoManager (#15688) - amp-ima-video: Suppress executing the IMA SDK library when consent state is unknown. (#15568)
- amp-next-page: optin the example page to the experiment. (#15639)
- Remove src/url requirement from amp-geo (#15689)
- Fix canonical -> cache URL rewriting (#15699)
- 🐛Fix date picker hanging when manually editing year (#15668)
Breakdown by component
ads
Update path and params for wisteria ad. (#15890)amp-3d-gltf
Validator rollup (#15873) amp-3d-gltf: fix test (#15860) amp-3d-gltf: fix src attribute (#15832) Remove flaky/non-functional integration tests (#15839) 🐛 fix alpha attribute (#15829) Lower-case amp-3d-gltf attribute names. (#15817)amp-a4a
Allow sending RTC with consentState policy adherence (#15951) Doubleclick experiment removing throttling for non-AMP creatives (#15954) Specify error reporting url for media.net RTC (#15902) 🚮 Gdpr Update: Removing Unnecessary GDPR Macros (#15849)amp-accordion
Add documentation for animate attribute on amp-accordion (#15958)amp-ad
🐛Support fullscreeningamp-ad-exit
Replace A4A with AMPHTML ad (#15895)amp-ad-network-doubleclick-impl
Update docs for doubleclick in stamp. (#15901) Update sf docs (#15876) 📖Update doc to reflect Fluid status beta->launched (#15861) Add DoubleClick documentations for Single Page Ads (#15833)amp-analytics
✨ Add "gtag" vendor configuration. (#15915) Fix more test-amp-analytics.js failures due to expected console errors. (#15963)amp-animation
Validator rollup (#15873)amp-audio
Validator rollup (#15873)amp-bind
Increment binding limit by 500 on user gesture (up to 2000) (#15985)amp-bodymovin-animation
Remove flaky/non-functional integration tests (#15839)amp-call-tracking
Docs - add links to ABE demos (#15900)amp-carousel
Validator rollup (#15873) Fix carousel scroll on unlayout race condition trying to access non-existant slide (#15823)amp-facebook-comments
Docs - add links to ABE demos (#15900)amp-facebook-like
Docs - add links to ABE demos (#15900)amp-facebook-page
Docs - add links to ABE demos (#15900)amp-fx-collection
Deal with clashing presets in amp-fx gracefully (#15938)amp-geo
🐛 make amp-geo use user().error() on bad json (#15877)amp-google-document-embed
✨Create amp-drive-viewer behind experiment (#15824)amp-google-vrview-image
Docs - add links to ABE demos (#15900)amp-ima-video
🐛Support fullscreeningamp-lightbox-gallery
Fix arrow keys disappear on second open bug (#15879)amp-next-page
🐛 amp-next-page: Fix trying to rewrite canonical URLs to cache URLs when it shouldn't (#15831) Validator rollup (#15873) ♻️ Remove src/url requirements from amp-next-page (#15840)amp-nexxtv-player
Skip flaky tests (#15981)amp-reddit
🐛Support fullscreeningamp-sidebar
Sidebar should not close when toolbar is present (#15990)amp-story
[amp-story-bookend] Replaces amp images to regular images in amp-story-bookend (#15904) Changes amp-story-bookend config to use camelcase (#15944) 🚀♻️Delegate autoplay using signal (#15952) Add experiment to disable amp-story desktop UI (#15937) Fixing bookend prompt consent margin when no config. (#15929) Disallows `bookend-config-src` attr in `amp-story` tag (#15846) Deprecate dismiss consent translation key. (#15908) Adding translation keys for the bookend prompt consent link. (#15910) Add a prompt consent button in the v0.1 bookend. (#15905) Update docs for doubleclick in stamp. (#15901) Add a prompt consent button in the bookend. (#15897) Fixing the bookend article layout. (#15899) Update whitelist: 2018-06-07 (#15896) Fixing the consent ID used by amp-story-consent. (#15881) Stories paused state, and state machine. (#15874) ♻️ Port amp-story info dialog to 1.0 (#15872) 🐛 Prevent setting min/max width/height on standalone amp-story elements (#15842) Whitelist origins for amp-story: week of 2018-06-05 (#15841)amp-story-auto-ads
Disallows `bookend-config-src` attr in `amp-story` tag (#15846)amp-timeago
Docs - add links to ABE demos (#15900)amp-twitter
🐛Support fullscreeningamp-user-notification
🏗 Allow duplicate error messages in `expectAsyncConsoleError` (#15936)amp-video
🐛 Work around Android blank frame issue (#15957)validator
🏗 Require JSDoc comments for all classes, methods, and functions in AMP code (#15977) Until now, `gulp lint` used to check existing JSDoc comments for correctness, but it didn't complain if they were missing.With this PR, we require JSDoc comments for all classes, methods, and functions in the AMP codebase. This is critical to our ability to speed up the compilation of the AMP runtime using closure compiler.
Since there are numerous instances of missing JSDoc comments, this rule will be run in warning mode for push builds on master
, while it will run in error mode on files touched by a PR (large refactors are exempted).
Remove inline installation (#15970)
Remove the inline installation of the AMP Validator Chrome Extension from the Validator WebUI.
Validator rollup (#15873)
Lower-case amp-3d-gltf attribute names. (#15817)
Lower-case amp-3d-gltf attribute names.
Fix test which was supposed to catch upper-case attribute names. The
regex was not anchored, so would pass if there was at least one
non-upper case character in the attribute name.
Resolves 2 of the 3 validation errors in #15793.