Version: 1516396600278
- amp-story progress-bar segment fills for current page (#12613)
- Add missing option to buildExtensions() in gulp watch / gulp build (#12911)
- amp-story initial load tweaks (#12842)
- amp-carousel : install input service before using it (#12910)
- Update the a4a spec to require amp-animation based on (#11769)
- Add instructions for using Typekit (#12602)
- Consolidate gulp watch and gulp build (#12900)
- Print CID API error response to browser console. (#12738)
- Support 'geo:' URL scheme for anchor href attributes. (#12904)
- [Prototype] Add exit animations to lightbox viewer back to source element (#12879)
- Auto install lightbox without adding a tag (#12873)
- Add lightbox-thumbnail-src attribute (#12877)
- Add Sidebar to FixedLayer after displaying (#12899)
- Fix carousel arrow disappearing on desktop without controls attr (#12894)
- Add Sidebar to FixedLayer after displaying (#12899)
- Fix carousel arrow disappearing on desktop without controls attr (#12894)
- Bless amp-story media on user navigation (#12892)
- Referenced templates also affect [submit-error] (#12813)
- [amp-audio] Adds preload attribute (#12832)
- fix animating circle fixed position (#12871)
- Start gulp server after build is complete (#12882)
- remove old error logging (#12875)
- Show the audio icon if there are media elements or background audio in the story (#12763)
- Use the proper getAttribute function for propagating image viewer aria attributes (#12872)
- Remove old error tracker (#12875)
- Remove the soon-to-be-deprecated gulp-util (#12825)
- Pull amp-image-viewer out into it's own component (#12810)
- Unskip test that fail with lolex v2 (#12858)
- Fix macros for RTC Doubleclick (#12841)
- Rewrite third_party/caja/compile.sh to use patches where possible (#12851)
- Remove ampcors check when fetching analytics remote config (#12787)
- no padding no back gradient (#12845)
- add on tap listener for multiple advance (#12844)
- Change how AMP inabox validates that the source of a postMessage is valid (#12541)
- Update amp4ads-amp-ad-exit test output. (#12846)
- amp-list: remove
src
when local data is used to render (#12861) - amp-ima-video: Ignore tap-and-drag to start video. Only start on tap without drag (#12803)
- Remove unnecessary pre-compiled file from package. (#12790)
- Adventive amp-ad type (#12742)
- cron job from @erwinmombay to update size.txt (#12833)
- Fix all remaining LGTM warnings in AMP code (#12826)
- amp-ad-exit layout validation (#12600)
- Yieldpro support (#12773)
- Remove greenkeeper token (#12822)
- No previous from tap on card on desktop (#12671)
- Update third_party/caja to v6012 (#12680)
- Fix primitive wrappers in Closure type tags (#12820)
- Hide text/icon on no previous page hint (#12796)
- no hint layer on vertical swipe (#12749)
- Allow objects to be given as macro values in RTC config (#12802)
- Only preload iframe transport client lib if needed (#12779)
- Set up Greenkeeper GH_TOKEN for PR builds (#12807)
- Add linter rule to prevent and fix redundant non-nullable primtives (#12809)
- Load amp-social-share when system share is supported (#12812)
- Added Nielsen support for EU (#12702)
- Trigger slidechange event from dynamic calls (#12814)
- Implement lightbox attribute for carousels (#12771)
- Remove fullscreen from amp-story (#12772)
- Preloading story bookend (#12783)
- Roll forward MediaPool changes and fix issues (#12604)
- Swap preact back in with race condition band-aided (#12784)
- Add yarn to PATH before installing greenkeeper-lockfile (#12791)
- Enable
greenkeeper-lockfile
to correctly findyarn
on Travis (#12789) - Fix LGTM errors in examples/ (#12777)
- Fix LGTM errors in 3p code (#12785)
- Fix LGTM errors in error.js (#12782)
- Validator Chrome Extension: Use tabs UserAgent in requests (#12750)
- Fix LGTM error in gulpfile.js (#12778)
- clean up tracker for document not visible error (#12698)
- Fix LGTM error in validator/chromeextension/popup-validator.html (#12781)
- Remove unused code (#12776)
- Fix LGTM errors in extensions/ (#12770)
- Fix LGTM errors in build-system/ (#12774)
- Fix LGTM errors in src/service/ (#12767)
Breakdown by component
ads
Adventive amp-ad type (#12742) Yieldpro support (#12773) Fix primitive wrappers in Closure type tags (#12820) Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-a4a
Allow objects to be given as macro values in RTC config (#12802) Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-access
Unskip test that fail with lolex v2 (#12858)amp-access-laterpay
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad
Unskip test that fail with lolex v2 (#12858) Adventive amp-ad type (#12742) Yieldpro support (#12773) Add linter rule to prevent and fix redundant non-nullable primtives (#12809) Fix LGTM errors in extensions/ (#12770)amp-ad-exit
Update amp4ads-amp-ad-exit test output. (#12846)amp-ad-network-adsense-impl
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad-network-cloudflare-impl
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad-network-doubleclick-impl
Fix macros for RTC Doubleclick (#12841) Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad-network-fake-impl
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad-network-gmossp-impl
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-ad-network-triplelift-impl
Add linter rule to prevent and fix redundant non-nullable primtives (#12809)amp-analytics
Remove old error tracker (#12875) Unskip test that fail with lolex v2 (#12858) Remove ampcors check when fetching analytics remote config (#12787) Only preload iframe transport client lib if needed (#12779) Remove unused code (#12776)amp-apester-media
Fix primitive wrappers in Closure type tags (#12820)amp-audio
[amp-audio] Adds preload attribute (#12832)amp-bind
Fix all remaining LGTM warnings in AMP code (#12826)amp-carousel
amp-carousel : install input service before using it (#12910) Fix carousel arrow disappearing on desktop without controls attr (#12894) Trigger slidechange event from dynamic calls (#12814)amp-date-picker
Swap preact back in with race condition band-aided (#12784)amp-ima-video
Fix primitive wrappers in Closure type tags (#12820)amp-image-lightbox
Fix all remaining LGTM warnings in AMP code (#12826)amp-image-viewer
[Prototype] Add exit animations to lightbox viewer back to source element (#12879) Use the proper getAttribute function for propagating image viewer aria attributes (#12872) Pull amp-image-viewer out into it's own component (#12810)amp-lightbox-viewer
[Prototype] Add exit animations to lightbox viewer back to source element (#12879) Auto install lightbox without adding a tag (#12873) Add lightbox-thumbnail-src attribute (#12877) Pull amp-image-viewer out into it's own component (#12810) Fix all remaining LGTM warnings in AMP code (#12826) Implement lightbox attribute for carousels (#12771)amp-list
amp-list: remove `src` when local data is used to render (#12861)amp-mustache
Referenced templates also affect [submit-error] (#12813)amp-sidebar
Add Sidebar to FixedLayer after displaying (#12899)amp-story
amp-story initial load tweaks (#12842) Bless amp-story media on user navigation (#12892) fix animating circle fixed position (#12871) Show the audio icon if there are media elements or background audio in the story (#12763) no padding no back gradient (#12845) add on tap listener for multiple advance (#12844) Fix all remaining LGTM warnings in AMP code (#12826) Hide text/icon on no previous page hint (#12796) no hint layer on vertical swipe (#12749) Load amp-social-share when system share is supported (#12812) Remove fullscreen from amp-story (#12772) Preloading story bookend (#12783) Fix LGTM errors in extensions/ (#12770)amp-web-push
Fix all remaining LGTM warnings in AMP code (#12826)validator
Support 'geo:' URL scheme for anchor href attributes. (#12904) Reference: https://en.wikipedia.org/wiki/Geo_URI_schemeFixes: #12888
Also removed comment about CITE
tag which seems to be old. The CITE
tag doesn't support URLs as an attribute. I suspect this comment intends to refer to the cite
attribute, but non http/https schemes don't make much sense for the cite
attribute.
Referenced templates also affect [submit-error] (#12813)
Validator updates
Remove the soon-to-be-deprecated gulp-util (#12825)
This PR does the following:
- Removes the soon-to-be-deprecated
gulp-util
package from AMP'sdevDependencies
. - Replaces
gulp-util.colors
withansi-colors.colors
(https://www.npmjs.com/package/ansi-colors) - Replaces
gulp-util.log
withfancy-log.log
(https://www.npmjs.com/package/fancy-log) - Replaces
gulp-util.PluginError
withplugin-error.PluginError
(https://www.npmjs.com/package/plugin-error)
See https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 for a detailed write up on why this is a good idea.
Fixes #12719
Remove unnecessary pre-compiled file from package. (#12790)
Validator Chrome Extension: Use tabs UserAgent in requests (#12750)
This is @jamesshannon code from #11831. Pulled in to resolve merge conflicts from #12733
Fix LGTM error in validator/chromeextension/popup-validator.html (#12781)
Fixes the following LGTM errors:
Partial fix for #12597