ampproject/amphtml 1463696122848

on GitHub

Version: 1463696122848

• Small lint fixes (from pulling this into our internal codebase). (#3262)
• Validator Updates while watching IO (#3261)
• Put the Github and Chrome extension links in the upper right (#3252)
• Add support for Sticky ad units in AMP #2472 (#3167)
• Added support for extraUrlParams in trigger blocks and URL vars. (#3168)
• In build.py, vulcanize the appengine validator webui app (#3248)
• Remove sidebar experiment. (#3249)
• Amp Flying Carpet (#3118)
• Updated e-planning adserver example (#3241)
• Add 3p scripts for microad.js (#3240)
• CSI measurements for authorization event (#3235)
• Disables cross-iframe code sharing for Twitter. (#3242)
• Add a favicon to the web ui. (#3238)
• Refactor amp-ad into extension (#2902)
• Validator NodeJS / cmd line update - Handle two more errors that can happen (#3237)
• Update the Appengine deployment for validator webui. (#3231)
• A NodeJS API for the validator. (#3086)
• make window config template prefixing be explicit (#3230)
• Fix for - amp-accordion: Uncaught TypeError (#3219)
• sort-time should not be the basis of any updates (#3217)
• add brotli compression size (#3224)
• Update size data (#3222)
• sports article sample with json-ld meta data (#2783)
• Support history on back button for amp-sidebar (#3210)
• Validator Updates (#3215)
• add amp_latest_update_time url param (#3202)
• Performance service moved to services (#3213)
• Fix issue with zeros when reporting access analytics (#3206)
• Build elements only when they are ready - @mkhatib (#3174)
• Server-side access prototype (#3200)
• Show progress indicator for youtube when it's loading (#3205)
• Intent to Implement MicroAd implementation for amp-ad (#3157)
• cron job from @erwinmombay to update size.txt (#3203)
• Added support for Linkpulse as a vendor in amp-analytics (#3158)
• always send prerenderComplete message to the viewer (#3198)
• Avoid loading external resources in tests (#3197)
• Allow passing data-params-* to amp-youtube (#3188)
• Port amp-instagram test to be hermetic (#3187)

Breakdown by component

ads

• Add 3p scripts for microad.js
• Intent to Implement MicroAd implementation for amp-ad

amp-access

• CSI measurements for authorization event
• amp extension documentation clean up for validation section
• Fix issue with zeros when reporting access analytics
• Server-side access prototype

amp-accordion

• Fix for - amp-accordion: Uncaught TypeError
• amp extension documentation clean up for validation section

amp-ad

• Amp Flying Carpet

amp-analytics

• Added support for extraUrlParams in trigger blocks and URL vars.
• amp extension documentation clean up for validation section
• Added support for Linkpulse as a vendor in amp-analytics

amp-anim

• amp extension documentation clean up for validation section

amp-audio

• amp extension documentation clean up for validation section

amp-brid-player

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-brightcove

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-carousel

• amp extension documentation clean up for validation section

amp-dailymotion

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-facebook

• amp extension documentation clean up for validation section

amp-fit-text

• amp extension documentation clean up for validation section

amp-font

• amp extension documentation clean up for validation section

amp-fx-flying-carpet

• Amp Flying Carpet

amp-iframe

• amp extension documentation clean up for validation section

amp-image-lightbox

• amp extension documentation clean up for validation section

amp-instagram

• amp extension documentation clean up for validation section
• Port amp-instagram test to be hermetic

amp-install-serviceworker

• amp extension documentation clean up for validation section

amp-jwplayer

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-kaltura-player

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-lightbox

• amp extension documentation clean up for validation section

amp-list

• amp extension documentation clean up for validation section

amp-live-list

• sort-time should not be the basis of any updates
• add amp_latest_update_time url param

amp-mustache

• amp extension documentation clean up for validation section

amp-pinterest

• amp extension documentation clean up for validation section

amp-reach-player

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-sidebar

• Remove sidebar experiment.
• amp extension documentation clean up for validation section
• Support history on back button for amp-sidebar

amp-social-share

• amp extension documentation clean up for validation section

amp-soundcloud

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-springboard-player

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-sticky-ad

• Add support for Sticky ad units in AMP #2472

amp-twitter

• amp extension documentation clean up for validation section

amp-user-notification

• amp extension documentation clean up for validation section

amp-vimeo

• amp extension documentation clean up for validation section
• Avoid loading external resources in tests

amp-vine

• Avoid loading external resources in tests

amp-youtube

• Allow passing data-params-* to amp-youtube

validator

• Small lint fixes (from pulling this into our internal codebase).

  • Validator Updates while watching IO

  Release Notes:

  • Allow shrink-to-fit for <meta name="viewport"...>
  • Support unqouted attribute values that have assignments within (htmlparser.js). - Put the Github and Chrome extension links in the upper right

  Also make them upper case, much like the entries on www.ampproject.org.

  PS: Now I'm starting to think I want the example buttons replaced
  with links like these as well (it'd reclaim space for showing the
  html source), but one thing at a time is probably best. :-) - In build.py, vulcanize the appengine validator webui app

  This inlines the javascript / css / html except for validator.js itself,
  reducing the number of requests and improving initial load time.
  To make this work, I tweaked validator/webui/index.html some and
  made build.py create a little temporary root with symlinks. This means
  I need to also adjust the webui command for index.js - but luckily
  the new version is simpler: it just looks up most resources relative
  to node_modules. Also, this simplifies app.yaml. - From the root README.md, link to validator/README.md.

  In validator/README.md:

  • Mention #development=1.
  • Slap (beta!) onto the three other choices listed here, just to be honest
    for now. :-) - Add a favicon to the web ui.

  I went with the one from www.ampproject.org.
  Also very slightly simplified the location for webcomponents-lite.js in the appengine app. - Validator NodeJS / cmd line update - Handle two more errors that can happen

  Handle two more errors that can happen

  • DNS resolution errors.
  • Syntax errors in the validator.js script, e.g. when
    something is specified that's not a validator.js file.

  Also I think for the command line it looks smoother
  to log the error message rather than the object, so I switched
  it to that.

  Example session with this change:
  $ ./index.js --validator_js https://www.google.com/ https://www.google.com/
  Could not instantiate validator.js - Unexpected token <
  $ ./index.js --validator_js https://www.google.com/ https://www.google.colm/
  Unable to fetch https://www.google.colm/ - getaddrinfo ENOTFOUND www.google.colm www.google.colm:443
  $ ./index.js https://www.google.com/
  ... this prints a whole bunch of validation errors as expected ... - Update the Appengine deployment for validator webui.

  @honeybadgerdontcare This is your change (thanks!) plus a small/simple/fast step to "build" in build.py.
  As for including or not including some App ID, one can specify this on the command line
  (--application) so it's not necessary to include this in app.yml, I think (https://cloud.google.com/appengine/docs/go/tools/appcfg-arguments).

  • Validator Updates