Soon after the release of v3.27.0 some minor bugs were noticed. This fixes those bugs:
- GANDI_V5's diff2 emits an empty log message when creating record
- Colorization doesn't work on diff2 (wasn't implemented)
- CLOUDFLAREAPI emits a record-ID for deletes, but not changes
- GCLOUD emits an extra newline in logs (diff1 and diff2)
- Integration test
TestDualProvidersdisplays logs with wrong newline
Meanwhile more cleanups were done:
- Removed a lot of old DEBUG statements that were commented out
- analyze.go contains multiple functions doing the same thing (remove the duplicates)
- clarify comments
- Use the more concise pattern of diff.NewCompat() (CSCGLOBAL, DIGITALOCEAN, NAMEDOTCOM)
- Many minor code fixes and cleanups
At this point the diff2 engine is ready for production testing. Please run dnscontrol --diff2 preview (and push) to verify that it operates as expected. Please report any bugs or even minor annoyances.
My hope is that diff2 will become the default in v3.29 or v3.30. When diff2 becomes the default, a --diff1 flag will be added to activate the old code. I'm not sure when the old code will be removed but I'm targeting May or June.
Changelog
Major features:
- e129e40: FEATURE: Colorize diff2 output (#2103) (@tlimoncelli)
Other changes and improvements:
- 2586e2b: CORE: Clean up diff2 code in prep for production (#2104) (@tlimoncelli)
- 26fb0f1: DOC: Fixed a bit of havoc which appears in go docs (#2101) (@systemcrash)