RocketChat/Rocket.Chat 6.2.0-rc.10

on GitHub

2023-05-11 · 3 🐛 · 4 🔍 · 7 👩‍💻👨‍💻

Engine versions

• Node: 14.21.3
• NPM: 6.14.17
• MongoDB: 4.4, 5.0, 6.0
• Apps-Engine: 1.39.0-alpha.219

🐛 Bug fixes

• app status inconsistencies when running multiple instances in a cluster (#29180)

  App status inconsistencies between multiple instances in a cluster boil down to the fact that the Apps-Engine is currently responsible for orchestrating when these events are triggered and is overly verbose in doing so.

  Upon analysis, the framework itself should not have the concept of "other instances" - this is a deployment detail of the host system, and as such should be controlled by the host. The correct solution for this problem is to review this notification system, potentially removing it from the framework and leaving the responsibility solely for Rocket.Chat.

  However, this is hindering the current app management experience for workspaces, so this PR cuts the control of some notifications that come from the framework (the more problematic ones) and moves the control over to RC in a short and practical way.

  This is done by turning the methods of the most problematic events in the AppActivationBridge into no-ops, and instead triggering the AppServerNotifier directly in the api endpoints that are applicable.

  It is not the most correct solution to the problem, but due to time constraints and urgency this will be applied first so we can move with the correct solution in a future point.

• Migration error when removing 'snipetted' index (#29215)

• migration to fix apps in invalid state (#29210)

  Due to a conflict between 5.4.x and 6.0, if the upgrade of a workspace is done using a Rolling upgrade strategy, it is likely that apps will be left in an invalid (potentially unusable) state.

  We can solve apps left in this state by adding another migration.

👩‍💻👨‍💻 Core Team 🤓

• @AllanPazRibeiro
• @Dnouv
• @KevLehman
• @d-gubert
• @murtaza98
• @sampaiodiego
• @tapiarafael