RocketChat/Rocket.Chat 5.4.0-rc.0

on GitHub

2022-11-23 · 9 🎉 · 13 🚀 · 61 🐛 · 64 🔍 · 53 👩‍💻👨‍💻

🎉 New features

• Add new endpoint 'livechat/agent.status' & deprecate changeLivechatStatus meteor method (#27047)

• Bugsnag client (#23580)

• Custom MessageType for video conference messages (#27333)

• Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)

  Currently the message parser does not accept Emphasis elements mixed with plain text

  [Normal Link - *Bold*, _Italic_ and ~strike~ Styles](https://rocket.chat/) return plain text → Should return a Lin with bold/italic/strike

  To fix this behavior it was necessary to edit LinkSpan component in gazzodown package (changes included in this PR) and the grammar/utils files in the fuselage/message-parser repository

  Fuselage Pull Request: RocketChat/fuselage#887

• Federation events coverage expansion (#27119)

  This PR adds the following features for the Matrix Federation feature:

  • Ability to sync Users' real names (since they have at least one room in common with other users);

  • Search for public channels given a server name;

• Incompatible Apps (#27280)

• REST API endpoint /v1/oauth-apps.create (#27054)

  Created the 'oauth-apps.addOAuthApp' endpoint for the apps/meteor/client/views/admin/oauthApps/OAuthAddApp.tsx file, and added Ajv validation.

• REST API endpoint /v1/rooms.delete (#26866)

• Video Conference Message blocks and info action (#27310)

🚀 Improvements

• Add message name container component to message name header and system message (#27184)

  Add MessageNameContainer wrapper to display name and username inline and separate them with a blank space.

  Update font size of system message:

  Before:
  

  After:
  

  Add removed message variation to ThreadMessageOrigin component
  Before:
  

  After:
  

• Add searchTerm support for livechat/rid/messages API (#27214)

• Add update option to apps list kebab menu and implement new update badge on apps list (#27246)

  Added a new update option to the app menu to follow the removal of the CTA buttons from the apps list. Also implemented the new update badge that will replace the old update button.
  Demo gif:
  

• Adding a noscript tag for letting users know if they have JS disabled (#23632 by @sidmohanty11)

• Improve searchChats endpoint to have source filter support (#27262)

• Login rewrite in react (#26782)

• Marketplace feedback toasts (#27239)

  Jira tasks

  Save app changes toast: MKP-160
  Uninstall app toast: MKP-168
  Enable/disable app feedback toast: MKP-169

  Implemented/refactored four toast notifications and refactored another two in marketplace. The first one happens after the user saves the settings of an app, the second one when the user successfully uninstalls an app and the third and fourth ones happen when the user enables and disables an app respectfully.
  Demo gif:
  

• Move app list install logic to app menu (#27056)

  Jira task: MKP-136

  Moved the install/buy/subscribe logic from the CTA buttons that existed in the app list to the app menu. Now the user can install apps by clicking in the kebab menu in the right of the app list entry. Also solved a little undefined bug happening in the app permissions modal.
  Demo gif:
  

• Quotes on E2EE Messages (#26303)

  This PR provides basic quoting to E2EE messages, it doesn't support multiple chaining of quotes messages.

  

• Read threads when marking a room as read (#26754)

  This PR changes the functionality of subscription.read to add read threads when endpoint is called

• Removed tool tip from sidebar menu (#24605 by @Himanshu664)

• Sorting functionality in team channel while leaving a team (#21790 by @sumukhah)

• VideoConf Miss Config Modal (#27153)

  Jira Issue: [VC-9]

  

🐛 Bug fixes

• Add condition to createUser button on UsersPage (#27189)

  Hide the create user button in admin if the user doesn't have the permission to do so. It was not the case before.

  2021-04-23.02-55-02.mp4

• Add condition to invite user if user doesn't have permission (#27190)

  If you deactivated the permission to send links, the button was always there and led to an error message.
  Before:

  2021-04-23.02-22-04.mp4

  After:

  2021-04-23.02-34-49.mp4

• Add pause functionality to Custom Sounds (#24361)

• Add sorting channels on teams (#21675 by @sumukhah)

• Adding error message for wrong dates (#21677 by @shrinish123)

  Before :
  

  After:

  

• Adjust read only toggle on create channel based on permissions (#27318)

• Adjusted form validation to disallow duplicated emails (#27037)

  This pull request revisits the user info form, fixing a bug that allowed the form to be saved with an already existing e-mail. Taking advantage of this opportunity this PR also refactors the file to typescript and adds new libs like useForm and useQuery.

• Always parse encrypted messages on client (#27092)

• Archived channels reappearing permanently (#20476)

• AttachmentDescription color token (#27222)

• Avg response time calculation (#27163)

• Change GridFS error message validation (#26957)

  Allow uninstalling an app even if source files cannot be found. This validation was already done in the past, but since the error message was changed, the validation was broken.

• Delete first message when initializing thread returns black screen (#27117)

• Discussion list timestamp and Edit room system messages (#27180)

• Discussions list divider on contextualBar (#27178)

• Display Edit Team instead of Edit Room when in a team (#27230)

• Ensure onetime job runs according to 'startupSetting' everytime (#27311)

  • Fixes the condition of not running a onetime job at the app's startup scheduled to run by using the startupSetting if the job was run previously at another app startup (Agenda does not remove already run jobs from the database, preventing the app from scheduling the job a second time as it thinks the job is already scheduled);

  • Declutters the scheduler's collection by removing onetime jobs documents after they are run.

• Featured apps disappearing, install toast config and save changes button behavior (#27181)

  Jira tasks

  Featured apps disappearing: MKP-161
  Install toast config: MKP-162
  Save changes button behavior: MKP-163

  Fixed three bugs: In the first one featured apps would disappear from the apps list after installation, in the second one the install toast wasn't correctly configured, and in the third one the app details page save button would render even when the current app wasn't installed.
  Demo gif:

  

• File upload receiving whole file to apply limits (#27105)

• Fixed Allow reacting toggle button in Edit room (#20324 by @Darshilp326)

  Users can now see changes for toggling allow reacting button after changes.
  Users do not need to come back for changing allow reacting button.

  Edit-Room-Pr.mp4

• Gap between message content and message header when there's no text. (#27165)

  Before:
  
  

  After:
  
  

  Additionaly removed a component that was being rendered inside itself, causing spacing issues.

• Hide system messages setting not being respected. (#27151)

  There was a query missing the parameters in the client.

  Also added a few tests to help reduce the risk of this happening again.

• Improper grammar when converting channel member to owner (#27265 by @JoshMcCullough)

• Install private apps modal behavior marketplace (#26973)

  Fixed two bugs in the private app install page:

  • The first one is a lack of pt-br translation to the agree button of the apps permission modal

  • The second one is that the review modal did not show the default permission list when the app being installed did not provide a permissions list.

  Demo gif:
  

• Integration history breaking when there's more than 49 records (#27290)

  Aditionally, fixed example data for incoming webhooks and converted some files to TS.

• LDAP "Sync Roles" option doesn't work for custom roles (#26842)

  Previously the sync of custom fields on LDAP wasn't working because the check was assuming that the name of the role is the same value from _id, which is the same for initial roles, but different for custom.

• LDAP groups to channel mapping attempts to create a new room instead of using an existing one (#27312)

  • Check rooms' name and display name in order to confirm they don't exist (and then try to create a new room).

• MarkdownText component not respecting Markdown_SupportSchemesForLink setting (#27245)

• Marketplace app details page back-button behavior (#27062)

  Jira task: MKP-26

  Fixed the behavior of the marketplace app details page back button. Now it will return the user to the page they accessed the app details from. Also, refactored the overall routing of the marketplace and removed the admin-apps route as everything is now handled by the admin-marketplace route.

  Demo gif:
  

• Message Parser version upgrade (#27284)

• Message search breaking URL, usertags and emojis (#20878 by @TBG-FR)

• Missing React When Read Only setting on Admin Rooms Edit (#27183)

  When the user was editing a room in the admin, he could not set React When Read Only because the option was not there unlike a normal room edit. So i added the option.

• Modifying userActionIndicator syntax for translations (#27004 by @TBG-FR)

• Multi instance error message (#27243)

• multiple user assigned for a role (#23741 by @Aman-Maheshwari)

• Navigate to home after deleting a channel from edit screen (#21602 by @sumukhah)

• Next schedule check for Apps (#27240)

• Removed mobile requirement for showing real name (#26968 by @TedsCabin)

  Removed the mobile requirement for allowing real names to be used in message headers.

• Replace regex not compatible with safari (#27294)

• Room Avatar being deleted after upload. (#27060)

  Remove avatar before updating it. S3 already overwrites the old image, but since this part of the code is shared among many other File Storage providers, we need to make this deletion before the upload.

• RoomForeword design (#27196)

  Before
  

  After
  

• Scrollable report message (#26853 by @yasemincidem)

• Set default value "false" for global search. (#25568 by @ivan1kazantsev)

  If we disable the "global search", then the "global search" checkbox removes from the UI. It's not what we want. I think, we should set the default to "false", because the default is to search inside the channel/dialog.

• Show a consistent name on information screen (#21603 by @sumukhah)

• Show Favorite icon only if user has joined room (#21976)

  Before: There was a favorite button even if the user hasn't joined the room

  After:

  

• Shrug missing backslash character (#27233)

  Previously the escape character \ was escaping everything.

  To avoid unexpected text formatting errors it was restricted to only escape curtains chars like: * _ ~ ` # .
  Doing so the Shrug had to change in the code to display the correct ASCII Art

• Sidebar context menu in searchList (#23830 by @Aman-Maheshwari)

  Removed onClose function from the Box Component inside searchList.js as this component wraps the complete list which is rendered and when clicked on the any rendered row inside the component it closes the searchList preventing the context menu to be displayed.
  Also added usePreventDefault hook.

  Before

  before_sidebar_contextmenu.mp4

  After

  after_sidebar_contextmenu.mp4

• Sidebar Room list extended preview not updating on new messages. (#27259)

• Sort RecordList items in REVERSE chronological order, not FORWARD (#27201 by @nmagedman)

  Sort items in the Files sidebar in reverse chronological order (newest at top, oldest at bottom), as it did before RC v3.11.0.

• The parent room icon is now clickable (#21655 by @shrinish123)

  The parent room icon as shown in the video was not clickable but the cursor type on the icon was a pointer. Now even clicking on the icon or anywhere on the parent room tag will redirect you to the parent room.

  Before :

  Untitled.project.Made.with.Clipchamp.2.mp4

  After:

  Untitled.project.Made.with.Clipchamp.3.mp4

• Thread view expand command in wide screens (#23136 by @edward-raven)

• ThreadRow hover color (#27166)

• UiKit modals taking 5 seconds to close (#27225)

• Upgrading fuselage package and fix quote message prepend (#27307)

  Adding heading styles to message

  [OLD] As it was before this change:

  

  [NEW] As it is NOW:

  

  ---

  Fix heading style in quote messages

  Before:
  

  After:
  

• Uploading Custom Sound files not working, but showing success (#27177)

• Use name if fname is undefined (#20459 by @aKn1ghtOut)

  In the default general room(and possibly in other cases), the fname property is not set. The site should use the "name" property as a fallback in such cases.

  After fix

  
  

• User approval email doesn't display username and e-mail when user logs in with OAuth (#27111)

• User auto complete breaks on enter key press (#27213)

• User email address does not change when provisioned by OAuth (#27148)

• User merge by e-mail on OAuth is case-sensitive (#27167)

  • Ignore case when searching for a user by email.

• UserCard not opening inside Threads (#27096)

👩‍💻👨‍💻 Contributors 😍

• @Aman-Maheshwari
• @Darshilp326
• @Himanshu664
• @JoshMcCullough
• @Kartik18g
• @TBG-FR
• @TedsCabin
• @aKn1ghtOut
• @aswinidev
• @dependabot[bot]
• @edward-raven
• @im-adithya
• @ivan1kazantsev
• @lucassartor
• @nmagedman
• @rettinghaus
• @satishp962
• @shrinish123
• @sidmohanty11
• @sumukhah
• @tusharxoxoxo
• @xareyli
• @yasemincidem

👩‍💻👨‍💻 Core Team 🤓

• @AllanPazRibeiro
• @KevLehman
• @LucianoPierdona
• @MarcosSpessatto
• @MartinSchoeler
• @aleksandernsilva
• @carlosrodrigues94
• @casalsgh
• @debdutdeb
• @dougfabris
• @felipe-rod123
• @filipemarins
• @gabriellsh
• @ggazzo
• @guijun13
• @hugocostadev
• @juliajforesti
• @matheusbsilva137
• @matheuslc
• @murtaza98
• @nishant23122000
• @pierre-lehnen-rc
• @rique223
• @sampaiodiego
• @tapiarafael
• @tassoevan
• @thassiov
• @tiagoevanp
• @weslley543
• @yash-rajpal