RocketChat/Rocket.Chat 4.8.0

on GitHub

2022-05-31 · 16 🎉 · 13 🚀 · 55 🐛 · 151 🔍 · 52 👩‍💻👨‍💻

Engine versions

• Node: 14.18.3
• NPM: 6.14.15
• MongoDB: 3.6, 4.0, 4.2, 4.4, 5.0

🎉 New features

• Ability for RC server to check the business hour for a specific department (#25436)

• Add expire index to integration history (#25087)

• Add new app events for pin, react and follow message (#25337)

• Add new events after user login, logout and change his status (#25234)

• Add option to show mentions badge when show counter is disabled (#25329)

• Add user events for apps (#25165)

• Adding app button on user dropdown (#25326)

• Alpha Matrix Federation (#23688)

  Experimental support for Matrix Federation with a Bridge

  Quick.Example.showing.Matrix.org.mp4

• Expand Apps Engine's environment variable allowed list (#23870 by @cuonghuunguyen)

• Federation (Alpha Stabilization) (#25457)

• Get user's preferred language via apps (#25514)

• Marketplace new app details page (#24711)

  Change the app details page layout for the new marketplace UI. General Task: MKP12 - New UI - App Detail Page

  MKP12 - Tab Navigation

  New tab navigation layout for the app details page. Now the app details page is divided into three sections, details, logs, and settings, that can each be accessed through a Tabs fuselage component.

  Demo gif:
  

  MKP12 - Header

  Implemented a new header for the marketplaces app details page.
  -Changed the size of the app name;
  -Implemented the app description field on the header;
  -Changed the "metadata" section of the header(The part with the version and author information) now it also shows the last time the app was updated;
  -Created a chip that will show when an app is part of one or more bundles and inform which are the bundles;
  -Implemented a tooltip for the bundle chips;
  -Created a new button + data badge component to substitute the current App Status;
  -Changed the title of the "purchase button". Now it shows different text based on the "purchase type" of the app;
  -Created a new Pricing & Status display which shows the price when the app is not bought/installed and shows the app status(Enabled/Disabled) when it is bought/installed;
  -Changed the way the tabs are rendered, now if the app is not installed(and consequently doesn't have logs and settings tab) it will not render these tabs;

  Demo gif:
  

  MKP12 - Configuration Tab

  Delivered together with the tab-navigation task. Changed the app settings from the details of the app to the new settings tab.
  Demo image:
  

  MKP12 - Log Tab

  Changed the place of the app logs from the page to the new logs tab. Also changed some styles of the logs accordions to fit better with the new container.

  Before:
  

  After
  

  MKP12 - Page Header

  Changed the design for the page header of the app details page from a title on the left with a save and back button on the right to a back arrow icon on the left side of the title with the save button still on the right. Also changed the title of the page from App details to Back.
  Edit: After some design reconsideration, the page title was changed to App Info.
  Demo gif:
  

  MKP12 - Detail Tab

  Implemented markdown on the description section of the app details page, now the description will show the detailedDescription.rendered (as rendered JSX) information in case it exists and show the description (a.k.a. short description) information in case it doesn't. Unfortunately, as of right now no app has a visual example of a markdown description and because of that, I will not be able to provide a demo image/gif for this PR.

  MKP12 - Slider Component

  Created an image carousel component on the app details page. This component receives images from the apps/appId/screenshots endpoint and shows them on the content section of the app details of any apps that have screenshots registered, if the app has no screenshots it simply shows nothing where the carousel should be. This component is complete with keyboard arrow navigation on the "open" carousel, hover highlight on the carousel preview and close on esc press.
  Demo gif:
  

• Message Template React Component (#23971)

  Complete rewrite of the messages component in react. Visual changes should be minimal as well as user impact, with no break changes (unless you've customized the blaze template).

  
  In case you encounter any problems, or want to compare, temporarily it is possible to use the old version

  

• New button for network outage (#25499)

  When network outage happens it should be conveyed to the user with special icon. This icon should not be clickable.
  Network outage handling is handled in https://app.clickup.com/t/245c0d8 task.

• New stats rewrite (#25078 by @ostjen)

  Add the following new statistics (metrics):

  • Total users with TOTP enabled;

  • Total users with 2FA enabled;

  • Total pinned messages;

  • Total starred messages;

  • Total email messages;

  • Total rooms with at least one starred message;

  • Total rooms with at least one pinned message;

  • Total encrypted rooms;

  • Total link invitations;

  • Total email invitations;

  • Logo change;

  • Number of custom script lines;

  • Number of custom CSS lines;

  • Number of rooms inside teams;

  • Number of default (auto-join) rooms inside teams;

  • Number of users created through link invitation;

  • Number of users created through manual entry;

  • Number of imported users (by import type);

• Star message, report and delete message events (#25383)

🚀 Improvements

• ENTERPRISE: Allow mapping LDAP groups to multiple RC roles (#23849)

  • Add support to mapping LDAP groups to multiple roles (by specifying arrays in the "User Data Group Map" enterprise setting.

• Add OTR Room States (#24565)

  Earlier OTR room uses only 2 states, we need more states to support future features.
  This adds more states for the OTR contextualBar.

  • Expired
  
  • Declined
  
  • Error
  

• Add tooltip to sidebar room menu (#24405 by @Himanshu664)

• add warnings for federation setup (#25684)

• Added MaxNickNameLength and MaxBioLength constants (#25231 by @aakash-gitdev)

• Added tooltip options for message menu (#24431 by @Himanshu664)

• Fix multiple bugs with Matrix bridge (#25318)

• Improve active/hover colors in account sidebar (#25024 by @Himanshu664)

• New admin settings Page (#25439)

  

• Pass allowDiskUse to channel aggregations on engagement dashboard (#22374)

• Performance for some Omnichannel features (#25217)

• Rename upgrade tab routes (#25097)

  Change 'upgrade tab' routes names from camelCase ('goFullyFeatured') to kebab-case ('go-fully-featured') due to URL naming consistency. Changed types, main function and test.

• Unify voip streams into single stream (#25108)

🐛 Bug fixes

• Add katex render to new message react template (#25239)

• Add open user card to user avatar (#25445)

• Add reaction not working in legacy messages (#25222)

• Added invalid password error message (#24714 by @Himanshu664)

• Adjust email label in Setup Wizard i18n files (#25260)

  • remove 'Company' label on onboarding email keys in certain languages

• AgentOverview analytics wrong departmentId parameter (#25073 by @paulobernardoaf)

  When filtering the analytics charts by department, data would not appear because the object:

  {
  value: "department-id",
  label: "department-name"
  }

  was being used in the departmentId parameter.

  • Before:
    

  • After:
    

• Change form body parameter charset to UTF-8 to fix issue #25456 (#25673 by @divinespear)

  since mscdex/busboy 1.5.0, new option named defParamCharset for form body parameter encoding is added with default value latin1, so unicode filenames are broken since 4.7.0.

  

• Change NPS Vote identifier + nps index to unique (#25423)

• Click to join button Jitsi Call (#25569)

  Added ToolboxProvider to MessageListProvider and fixed actionLink.js open function exec

• Client disconnection on network loss (#25170)

  Agent gets disconnected (or Unregistered) from asterisk in multiple ways. The goal is that agent should remain online
  unless agent explicitly logs off.
  Agent can stop receiving calls in multiple ways due to network loss. Network loss can happen in following ways.

  1. User tries to switch the network. User experiences a glitch of disconnectivity. This can be simulated by turning the network off
     in the network tab of chrome's dev tool. This can disconnect the UA if the disconnection happens just before the registration refresh.

  2. Second reason is when computer goes in sleep mode.

  3. Third reason is that when asterisk is crashed/in maintenance mode/explicitly stopped.

  Solution:
  The idea is to detect the network disconnection and start the start the attempts to reconnect.
  The detection of the disconnection does not happen in case#1. The SIPUA's UserAgent transport does not
  call onDisconnected when network loss of such kind happens. To tackle this problem, window's online and offline event handlers are
  used.

  The number of retries is configurable but ideally it is to be kept at -1. Whenever disconnection happens, it should keep on trying to
  reconnect with increasing backoff time. This behaviour is useful when the asterisk is stopped.

  When the server is disconnected, it should be indicated on the phone button.

• Close room when dismiss wrap up call modal (#25056)

• Custom sound error toast messages (#24515 by @Himanshu664)

• Deactivating user breaks if user is the only room owner (#24933 by @sidmohanty11)

  Before

  deactivating-user-breaks.mp4

  After

  fix.deactivating-user-breaks-room-with-no-owner.mp4

• Desktop notification on multi-instance environments (#25220)

• End call button disappearing when on-hold (#24936)

• Failure to update Integration History index (#25473)

• Fix max-width message block (#25686)

• Fixing app contextual bar functionality (#25615)

• Fixing Network connectivity issues with SIP client. (#25391)

  The previous PR #25170 did not handle the issues completely.
  This PR is expected to handle

  1. Clearing call related UI when the network is disconnected or switched.

  2. Do clean connectivity. There were few issues discovered in earlier implementation. e.g endpoint would randomly
     get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the
     removal of contact on asterisk. This should be fixed in this PR.

  3. This PR contains a lot of logs. This will be removed before the final merge.

• FormData uploads not working (#25069)

• Full error message is visible (#24856 by @Himanshu664)

• Incorrect websocket url in livechat widget (#25261)

• Integrations avatar attribute misuse (#25283)

• Invitation links don't redirect to the registration form (#25082)

• Message menu action not working on legacy messages. (#25148)

• Message menu dropdown not working on Mobile Web (#25616)

• Message preview not available for queued chats (#25092)

• NPS never finishing sending results (#25067)

• Ordered and unordered list styles, Line breaks. (#25494)

  Also removed the message.md cache from server, since changes in the parser might break messages in the future (and will in this specific case).

• Pinned Message display cutting off information (#25535)

• Prevent federation crash on invite users as a non-owner user (#25683)

• Prevent sequential messages edited icon to hide on hover (#24984)

  before

  

  after

  

• Proxy settings being ignored (#25022)

  Modify Meteor's HTTP.call to add back proxy support

• Quote message spacing (#25613)

• Read receipts show with color gray when not read yet (#25244)

• Read receipts showing before message read (#25216)

• Remove 'total' text in admin info page (#25638)

  • Remove initial 'total' text from rooms and messages groups in the admin info page

  • Add 'total' before 'rooms' and 'messages' title on the same section. To use the new 'Total Rooms', was created a new key in the en.i18n.json file.

• Removing user also removes them from Omni collections (#25444)

• Replace encrypted text to Encrypted Message Placeholder (#24166)

  before

  

  after

  

• Reply button behavior on broadcast channel (#25175)

  Hide reply button for the user that sent the message

• room creation fails if app framework is disabled (#25200)

• Rooms' names turn lower case on CSV import (#24612)

  • Change 'Settings' import to not get cached configs

  • Remove update UI_Allow_room_names_with_special_chars value

• Sanitize customUserStatus and fix infinite loop (#25449)

  Additional improves:

  • usage of RHF to avoid unnecessary Add and Edit components separately and form validation

  • usage of GenericTableV2 and some hooks to avoid unnecessary code

  • fix IUserStatus type

  • improves in UI design

  • improves empty and loading state

  • improves files structure

  [LOOP ERROR ATTACHMENT]
  

• Settings listeners not receiving overwritten values from env vars (#25448)

• Showing Blank Message Inside Report (#25007 by @nishant23122000)

  Desktop.2022.03.31.-.15.58.05.02.mp4

• Toolbox hiding under contextual bar (#25237)

• Unable to see channel member list by authorized channel roles (#25412)

• Upgrade tab loader in incorrect position (#25398)

  • Add invisible prop to iframe when loading state is active.

• Upgrade Tab showing for a split second (#25050)

• Use correct room property for call ended at (#24932)

• useCurrentChatTags is not a function (#25604)

• UserAutoComplete not rendering UserAvatar correctly (#25055)

  before

  

  after

  

• UserCard sanitization (#25089)

  • Rewrites the component to TS

  • Fixes some visual issues

  before

  

  after

  

• Video and Audio not skipping forward (#19866)

• VoIP disabled/enabled sequence puts voip agent in error state (#25230)

  Initially it was thought that the issue occurs because of the race condition while changing the client settings vs those settings reflected on server side. So a natural solution to solve this is to wait for setting change event 'private-settings-changed'. Then if 'VoIP_Enabled' is updated and it is true, set voipEnabled to true in useVoipClient.ts (on client side)

  It was realised that the race does not happen because of the database or server noticing the changes late. But because of the time taken to establish the AMI connection with Asterisk.

  Solution:

  1. Change apps/meteor/app/voip/server/startup.ts. When VoIP_Enabled is changed, await for Voip.init() to complete and then broadcast connector.statuschanged with changed value.

  2. From apps/meteor/server/modules/listeners/listeners.module.ts use notifyLoggedInThisInstance to notify all logged in users on current instance.

  3. in apps/meteor/client/providers/CallProvider/hooks/useVoipClient.ts add the event handler that receives this event. Change voipEnabled from constant to state. Change this state based on the 'value' that is received by the handler.

👩‍💻👨‍💻 Contributors 😍

• @Himanshu664
• @aakash-gitdev
• @cuonghuunguyen
• @dependabot[bot]
• @divinespear
• @eduardofcabrera
• @kibonusp
• @lingohub[bot]
• @nishant23122000
• @ostjen
• @paulobernardoaf
• @sidmohanty11

👩‍💻👨‍💻 Core Team 🤓

• @AllanPazRibeiro
• @KevLehman
• @MarcosSpessatto
• @MartinSchoeler
• @PedroRorato
• @alansikora
• @albuquerquefabio
• @aleksandernsilva
• @amolghode1981
• @carlosrodrigues94
• @cauefcr
• @d-gubert
• @debdutdeb
• @dougfabris
• @felipe-menelau
• @felipe-rod123
• @filipemarins
• @gabriellsh
• @geekgonecrazy
• @ggazzo
• @guijun13
• @hugocostadev
• @jeanfbrito
• @juliajforesti
• @marceloschmidt
• @matheusbsilva137
• @matheuslc
• @murtaza98
• @pierre-lehnen-rc
• @rique223
• @rodrigok
• @sampaiodiego
• @souzaramon
• @tapiarafael
• @tassoevan
• @tiagoevanp
• @tmontini
• @ujorgeleite
• @weslley543
• @yash-rajpal