Overview
This is a maintanance release with small bugfixes, code cleanup, documentation improvements and a better overall PHPStan coverage.
We're also bumping the minimum required PHP version to 7.3 with intl extension enabled.
Our source code finally has a much better "copyright" section, to thank all the team that is contributing to this beautiful project.
Important things you should check before upgrading
This release requires PHP 7.3 with intl extension, do not upgrade if your system doesn't match this requirement.
What's Changed
- Fixed whitespace for docblocks by @fballiano in #2550
- Remove redundant polyfill code for error reporting constants by @elidrissidev in #2555
- Fixed whitespace for docblocks by @fballiano in #2556
- Some CSS fixes to OpenMage adminhtml theme by @sreichel in #2422
- Fixed whitespace for docblocks by @fballiano in #2558
- Set default width for grid datetime columns, ref #2239 by @sreichel in #2544
- Removed PHP 5.3 compatibility code from Mage_Adminhtml_Model_System_Config_Backend_Locale_Timezone by @fballiano in #2563
- Added info about targetNamespace change in README by @fballiano in #2559
- Removed unused controller Mage_Shipping_ShippingController by @fballiano in #2564
- phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract by @sreichel in #2565
- Ignore scss-cache and .phar files in .gitignore by @sreichel in #2566
- Changed boolean/integer to bool/int in docs by @sreichel in #2567
- Fixed whitespace for docblocks by @fballiano in #2562
- An Exception is thrown and logged if file is not found while merging by @fballiano in #2445
- Fixed PHPStan error with Mage_Catalog_Model_Resource_Product_Option_Collection by @fballiano in #2572
- Make php7.3 minimum requirement by @sreichel in #2413
- Added missing css.map file by @sreichel in #2573
- Added php-extension "intl" as requirement, updated composer by @sreichel in #2437
- Delete Mage_AmazonPayments.csv by @elidrissidev in #2579
- Update label for
system/csrf/use_form_keyconfig by @elidrissidev in #2578 - Refactoring: Replace dirname(FILE) With Corresponding Constant by @Sdfendor in #2582
- Fixed some docs for phpdocumentor by @sreichel in #2577
- phpstan: added some return statements to match parent class or interface by @sreichel in #2574
- phpstan: return type fixes by @sreichel in #2587
- Use null coalescing operator by @sreichel in #2543
- Updated phpstan experimental by @sreichel in #2589
- Fix Phpdoc Typos in Various Files by @Sdfendor in #2591
- phpstan: fixed "Access to an undefined property" by @sreichel in #2554
- Strip null bytes from strings and filter conditions. by @colinmollenhour in #1430
- Fixed phpstan-workflow by @sreichel in #2593
- Some fixes for phpdocs by @sreichel in #2588
- Removed Mage_GoogleBase.csv by @sreichel in #2599
- Better admin/config validation for allowed currencies by @sreichel in #2597
- Fix admin grid filter, ref #1430 by @sreichel in #2602
- [backport] Aggregate most viewed products report daily via a Cron job (#1829) by @sreichel in #2610
- Update deprecated using ${var} in lib/Zend by @sreichel in #2611
- Fix integers being cast to decimal in some particular cases by @digitalpianism in #1198
- phpstan: fixes for Mage_Catalog_Model_Product_Type_Abstract by @sreichel in #2605
- phpdocs: Undefined methods by @sreichel in #2613
- Downgraded composer dependencies to also fit php7.3 by @sreichel in #2576
- Added two indexes on sales_flat_order and sales_flat_order_item tables by @fballiano in #2447
- Phpdocs/phpstan update by @sreichel in #2596
- Replace Date Format String Literals With Existing Constants by @Sdfendor in #2592
- [PHP 8.1] Fix passing null to preg_split limit param by @elidrissidev in #2616
- Updated github workflow by @sreichel in #2608
- Updated README by @sreichel in #2618
- Fixed detect changes in custom options section (product edit) by @fballiano in #2444
- Add/Remove mark when region/zip is required by @luigifab in #2149
- Optimize EAV collections by @Sekiphp in #911
- Convert Exception to Throwable in Mage_Core_Block_Template. by @kiatng in #2623
- Added css class for sorted columns by @sreichel in #2604
- Improvements in cron scripts by @fballiano in #2380
- Fixed javascript error on adminhtml login page caused by #2149 by @fballiano in #2624
- Fixed bug caused by #2605 by @fballiano in #2625
- Fix workflow badges in README by @elidrissidev in #2626
- Update hardcoded credit card message in checkout by @elidrissidev in #2628
- bugfix + add module names to helper by @sreichel in #2617
- Get catalog search result collection from engine by @elidrissidev in #2634
- Add PHP dependencies security check workflow by @elidrissidev in #2639
- [security-workflow] Fixed cron syntax by @sreichel in #2640
- Add OpenMage Contributors Copyright by @justinbeaty in #2295
- docs: added ddev snippets by @sreichel in #2575
- Only run workflows when relevant files change by @elidrissidev in #2641
- Add back notification popup severity icons URL by @elidrissidev in #2633
- Fixes issue #475, reduce reprocessed jpeg image file size by defaulting image quality to 85% by @kiatng in #2629
- Prevent from editing a non-editable Order by @elidrissidev in #2632
- Allow automatic full invoice from API by @luigifab in #2393
- Add check if array key exists before use it by @przemyslaw-p in #2649
- Reload admin ACL by @luigifab in #1714
- Fixed Mage_Catalog_Model_Product_Status::addSaleableFilterToCollection() does nothing by @fballiano in #2603
- Reindex EAV values only for active storeviews by @fballiano in #2651
- Check if remote storage is enabled before saving local file by @elidrissidev in #2627
- Phpstan: fixed return types (docs only) by @sreichel in #2636
- Cast getLoadingTimeout() to int in template by @sreichel in #2661
- Fixes #2658 by @sreichel in #2662
- Re-added composer validation to github workflow by @sreichel in #2667
- Fix bug on clonePosition() in prototype.js. by @kiatng in #2669
- Fixes phpunit-workflow by @sreichel in #2672
- Reduce getId calls by @luigifab in #2677
- Allow to save configuration without fields by @luigifab in #2679
- Do not crash when creditmemo does not exist by @luigifab in #2684
- Fix esi parsing with turpentine by @luigifab in #2682
- Remove try catch throw by @luigifab in #2676
- Version bump in preparation for release by @fballiano in #2688
Full Changelog: v19.4.18...v19.4.19