GitoxideLabs/gitoxide gix-transport-v0.46.0

gix-transport v0.46.0

on GitHub

Changed

• don’t send plaintext credentials even with debug_assertions
  This should hopefully not be a breaking change, as the same code could
  produce the same behaviour if compiled with different flags. However,
  it’s possible some downstream test suites could be affected and
  will need to opt in to the feature.

Bug Fixes

• Honor disallow_shell in SSH client feature check
  When running an SSH client, the disallow_shell option determines
  whether the client command, before arguments, is to be run directly
  or if it is to be run by a shell.

  (One example of when it is run directly is if it comes from the
  GIT_SSH environment variable, while one example of when it is run
  by a shell is if it comes from the GIT_SSH_COMMAND environment
  variable.)

  When invoking the client in the most central and common case of
  actually attempting to connect to a remote server, disallow_shell
  was already followed. However, in some cases we are not sure what
  kind of SSH client program we have, and so to find that out (so we
  know how to run it to connect to a server), we run a test command,
  to see if it recognizes -G as OpenSSH clients do. Often we can
  tell what kind of client program we have without needing to do
  that. But if we do need to do it, we pre-run the client to check.
  In this use, the disallow_shell option was not followed, and
  instead the use of a shell was unconditionally treated as allowed.

  This fixes that by setting prepare.use_shell = false on a
  constructed gix_command::Prepare instance, which seems to be the
  prevailing style for achieving this elsewhere in gix-transport.

Commit Statistics

• 18 commits contributed to the release.
• 2 commits were understood as conventional.
• 0 issues like '(#ID)' were seen in commit messages

Thanks Clippy

Clippy helped 1 time to make code idiomatic.

Commit Details