GitoxideLabs/gitoxide gix-odb-v0.84.0

gix-odb v0.84.0

on GitHub

Refactor (BREAKING)

• add object_hash to gix-odb::Store::at_opts() and remove it from options
  This aligns at and at_opts, putting mandatory information as separate parameters.

New Features (BREAKING)

• require object_hash in Store::at
  Split Store::at_opts for callers that want to pass Options.
• (re-)introduce at(path, hash_kind)
  This way, a hash must be chosen, so that SHA-1 isn't hardcoded anymore.

Changed (BREAKING)

• fall back to the raw text when unquoting fails.
  Both callers of gix_quote::ansi_c::undo() turned a failure into an error of
  their own, while Git keeps the raw, still-quoted token as the value:

  • parse_attr_line() in attr.c falls through to its unquoted branch
  • Git's alternates parsing in odb.c spells the unterminated case out in a
    comment of its own

  For attributes this also covers invalid escapes, which were previously a hard
  error for the whole line. Git keeps "\!x" as the pattern, where the backslash
  goes on to escape the ! for the matcher rather than negating the pattern.

  Both fall back before checking for the [attr] macro prefix, as Git does, so a
  line like "[attr]x stays a pattern on either side.

  The Unquote variants are unreachable now and have been removed.

Test

• use gix_testtools::object_hash in a few tests

• explicitly pass Sha1 for static fixtures

• exercise alternates parsing without touching the filesystem.
  The previous test reached content() through alternate::resolve(), which meant
  creating a directory whose name begins with the quote that is never closed. That
  is not a legal filename on Windows, where it failed with InvalidFilename.

  Calling content() directly tests the same parsing without a filesystem, and
  adds a companion case showing that intact quoting still decodes its escapes.

New Features

• expose alternate-file parsing via alternate::parse()
  This is mostly for completeness and more low-level access.

Bug Fixes

• detect alternate cycles hidden by root siblings.

  Alternate directories were marked as seen when all siblings were queued.
  If a root listed both A and B while A and B pointed at each other, their
  first-discovery parents were both the root. Duplicate checks then found neither
  directory in the other sibling ancestry and missed the real back-edge.

  Process candidate edges depth-first before later siblings, matching Git’s
  recursive alternate ODB traversal. A duplicate is now checked against the
  ancestry of the traversal that reached it, so back-edges produce Error::Cycle
  while shared nodes in a diamond remain harmless deduplicated entries. Add a
  regression test for the root/A/B case.

• don't treat a shared alternate object directory as a cycle.

Bug Fixes (BREAKING)

• remove gix_odb::at()

Commit Statistics

• 28 commits contributed to the release over the course of 30 calendar days.
• 30 days passed between releases.
• 11 commits were understood as conventional.
• 0 issues like '(#ID)' were seen in commit messages

Commit Details