Fix: Judgment Day v1.4 — Smarter Convergence
Judgment Day was taking 5 review rounds when 2 should suffice. Three root causes identified and fixed.
Changes
Warning Classification (Pattern 3)
- Judges now classify
WARNING (real)vsWARNING (theoretical) - Real: "Can a normal user trigger this?" → YES → fix required
- Theoretical: requires malicious input, renamed home dir, race in <1ms → reported as INFO, does not block
- Theoretical warnings appear in the final report for awareness but do NOT trigger re-judgment
Convergence Threshold (Pattern 5)
- Round 1: present verdict to user, ASK before fixing (no auto-fix)
- Round 2+: only re-judge if confirmed CRITICALs remain
- Real WARNINGs fixed inline without re-launching judges
- Approved criteria: 0 CRITICALs + 0 real WARNINGs = APPROVED
Fix Agent Scope Rule
- New instruction: "If you fix a pattern in one file, search for the SAME pattern in ALL other files and fix them ALL"
- Inconsistent fixes across files were the #1 cause of unnecessary re-judge rounds
User Confirmation Gate
- Orchestrator now presents the verdict table and ASKS before fixing
- User can say YES, NO (escalate), or give specific feedback to adjust the fix list
Evidence
Tested on a real 1200+ line feature (backup retention). Before v1.4: 5 rounds, 37 fixes. With v1.4 rules: would have been 2 rounds.