Bug Fixes (BREAKING)
-
packet-line progress loop is now interruptible.
WithSidebands may loop internally to consume remote progress, but that
doesn't play well if this reader is supposed to be interruptible, as
interrupt checks are implemented on the outer layer, not on the innermost one.Now the progress handler can return a flag indicating whether to continue or
abort, which allows the caller to check for interrupts, and thus abort the inner
loop. -
rename
WithSidebands::read_line()
to*::read_line_to_string()
.
Also, we remove the existing blockingread_line()
override as it's not
representable in the async implementation anyway, to unify both implementations
once again.The new name also makes sure that we are not accidentally calling a built-in
implementation on theBufRead
trait as it's clear our method has to be called
under a different name.
Commit Statistics
- 6 commits contributed to the release over the course of 4 calendar days.
- 21 days passed between releases.
- 2 commits were understood as conventional.
- 0 issues like '(#ID)' were seen in commit messages