Byron/gitoxide gix-config-v0.34.0

gix-config v0.34.0

on GitHub

Bug Fixes

• assure excessive amounts of newlines can't lead to amplification.
  Now we won't read more than 1024 newlines in a row, which leads to
  a protection from specifically crafted configuration files which
  can amplify themselves when large amounts of edits happen on them.

  If somebody where to create a lot of sections based on one that
  has a huge amount of newlines before it, this whitespace would
  be retained with each new section, causing huge files to be created
  in memory that cause great delays when writing the file back
  and re-reading it.

  Maybe there would have been a way to avoid copying excessive amounts
  of whitespace when altering a section, or maybe one could also
  have adjusted the fuzz-test that found it [1].
  This would, however, have been much harder and time-consuming to
  implement for dubious value.

Bug Fixes (BREAKING)

• greatly reduce peak memory usage when reading files.
  Previously it was possible to cause a memory consumption of 2.5GB
  by merely reading a specifically tuned configuration file sized a little
  less than 1MB, a massive 2500x amplification.

  Data structures have been optimized and premature optimizations removed
  in favor of much more efficient memory usage.

  Now the same file causes a 36MB peak memory usage, still quite a lot,
  but also ~70x less than before.

Commit Statistics

• 11 commits contributed to the release over the course of 20 calendar days.
• 20 days passed between releases.
• 2 commits were understood as conventional.
• 0 issues like '(#ID)' were seen in commit messages

Commit Details