Stop counting muted findings, show which devices, honour maps_enabled
Three reports from @Orhideous.
Muted findings were still counted (#157)
The server marks a suppressed finding rather than removing it -- hiding it
outright would make the posture unauditable -- and already excludes it from
the hardening score. Every count in the UI ignored the mark.
The page contradicted itself on screen: each muted row renders the words
"not counted", directly beneath a header counting it. Confirmed against a
device with two findings, one suppressed: score moved 94 -> 97 because the
server excluded it, while the UI went on saying "2 issues found".
The cause was four separate call sites each filtering checks inline for
their own purposes, none aware of suppression. Counting now lives in one
tested helper so a fifth cannot reintroduce it.
Muted findings are reported rather than silently dropped: "1 issue found,
1 muted", a "+2 muted" note on Total findings, and a muted badge per device.
A device whose only findings are muted now reads Clean, which it did not.
Common Findings said how many, never which (#158)
He proposed deleting the card. I have made it answer the question instead:
each row expands to the device names. A tally with no way to reach the
devices is a dead end, but the aggregate itself is worth having -- it is the
only view that says "eleven devices share this problem".
It also counted muted findings, same as everything else.
maps_enabled did not cover the dashboard (#159)
A genuine regression against #106. The setting exists so operators on
isolated networks make no third-party tile requests and disclose no device
locations. It was honoured on the device page and the sites view, and not on
the dashboard -- the one place a map renders without anyone asking for it.
The dashboard never read app settings at all.
Verified end to end on the running stack, and the test suppression removed
afterwards. Full preflight green.
Container image: ghcr.io/2gt-media-group-llc/mikrotik-manager:0.24.21-beta
Documentation: https://2gt-media-group-llc.github.io/mikrotik-manager/