fix(firmware): verify a non-download instead of assuming it (v0.24.10-beta)
A report of instant download failures that I could not reproduce — three
devices upgraded 7.24.2 -> 7.24.3 here, including a parallel wave — but the
shortcut added in v0.24.8 deserved the suspicion regardless.
That change treated a final status of "New version is available" as conclusive
proof the download never landed, and failed at once. It is conclusive on the
RouterOS builds tested here, where the command blocks and streams progress. It
is not safe as an assumption: a build that dispatches the download and returns
immediately would report exactly that for a download which is merely starting,
and the result would be a confident, instant failure on a working upgrade.
The claim is now checked rather than trusted. Three polls ask whether progress
appears; if it does, this was an early return and the normal wait takes over.
Only a status that has not moved after thirty seconds is reported as a
failure, and the message says how long it waited.
This keeps what v0.24.8 was for — a refusal reported in a minute rather than
after ten minutes of silence — without betting the outcome on one observed
behaviour.
Verified on hardware against the real 7.24.3 release: an access point, a
switch, and a two-device parallel wave all upgraded cleanly, plus a
7.24.3 -> 7.23.6 -> 7.24.3 round trip on the test switch afterwards.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Container image: ghcr.io/2gt-media-group-llc/mikrotik-manager:0.24.10-beta
Documentation: https://2gt-media-group-llc.github.io/mikrotik-manager/